Project: Image Services Gen2 #445
Conversation
* image gen2 * nit * lint * fix strenum import * sort imports * add int test * address comments * rename
yec-akamai
requested review from
lgarber-akamai and
ezilber-akamai
and removed request for
a team
There was a problem hiding this comment.
I got an error when running make testint TEST_SUITE=linode_client locally. It doesn't seem to be related to the changes though. I tried in a different branch and saw the same error.
_______________________________________________________________________________________ test_get_account_settings _______________________________________________________________________________________
test_linode_client = <linode_api4.linode_client.LinodeClient object at 0x104a0f100>
def test_get_account_settings(test_linode_client):
client = test_linode_client
account_settings = client.account.settings()
assert account_settings._populated == True
> assert re.search(
"'network_helper':True|False", str(account_settings._raw_json)
)
E assert None
E + where None = <function search at 0x102ac54c0>("'network_helper':True|False", "{'managed': True, 'network_helper': True, 'longview_subscription': 'longview-100', 'backups_enabled': True, 'object_storage': 'active'}")
E + where <function search at 0x102ac54c0> = re.search
E + and "{'managed': True, 'network_helper': True, 'longview_subscription': 'longview-100', 'backups_enabled': True, 'object_storage': 'active'}" = str({'backups_enabled': True, 'longview_subscription': 'longview-100', 'managed': True, 'network_helper': True, ...})
E + where {'backups_enabled': True, 'longview_subscription': 'longview-100', 'managed': True, 'network_helper': True, ...} = AccountSettings: True._raw_json
|
I'm also running into a 404 when running |
Interesting, I've hardcoded the region to be us-east and it should work. Do you have the customer tag we mentioned in the thread? |
|
@ezilber-akamai For the account settings test, it looks like the regex is looking for I think the corrected pattern would look like this: 'network_helper':\s*(True|False)If we don't want to include that fix in this PR since it's out of scope, it might be ticket-worthy 🙂 |
Good point! I included this fix in the PR. Also I changed a bit the get random region function to make sure we only get core site for testing. Some of the functions are not available in non-core sites. |
|
LGTM tests pass locally |
📝 Description
Project Image Gen2 LA